L.A.
I practice attachment parenting. I didn't know there was a name for it when I had my first son, but I followed my maternal instinct instead of what other people told me to do. After he was a year old, I learned that there was a name for what I was doing. Co-sleeping and extended nursing are two big parts of attachment parenting, but the main gist of it is that you let your child tell you what they need and you give it to them. And all kids go through stages, whether it be waking in the middle of the night to play or to eat more while they are growing.
I co-slept with my oldest son who is now five. He slept in my bed with me until he was four years old when he wanted to sleep in his own bed. With him, I often nursed him several times a night until he was three years old. The pediatrician said he should be sleeping through the night by one year, but I followed my gut and let him nurse - either for hunger or for comfort - until he was ready to give it up. He is not spoiled nor does he have any weird attachment issues with me. When he was little he only wanted to be with me all the time and would rarely go to others. He outgrew that all on his own and has become very independent because of the solid foundation of security he was given.
With my youngest son, who is now 14 months old, he doesn't eat as much so he sleeps through the night most nights without wanting to nurse. Sometimes when he is not feeling well he will nurse throughout the night, but for the most part he is a really good sleeper. All kids have different personalities and food requirements.
In answer to your question, you should follow your heart and not what other people tell you. Even if people think your child is spoiled because you coddle him, he will outgrow it. I know of no 18 year old kids who still need to nurse or don't sleep through the night without their M.! Some kids just need extra time nursing while they are growing (emotionally or physically.)
The great thing about co-sleeping is that you can feed them and go right back to sleep, usually without either of you waking up completely. They get a full tummy or comfort and you don't have to lose any sleep.